Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

This PR is purely refactoring in an effort to build consistency and align the code/outputs of various linters.

Best reviewed commit-wise:

  • Changing the type checker to allow a function to assert when the desired type has been unpacked
  • Updating the NoDurations linter to leverage the type checker
  • Aligns earlier type checker based linters to use the inspector helper
  • Update the NoMaps linter to leverage the type checker

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2025
@JoelSpeed
Copy link
Contributor Author

@sivchari @Karthik-K-N You've both been working these linters recently so might be good to get one or both of you to review please

@JoelSpeed JoelSpeed force-pushed the broader-type-checker branch from 6e5cb47 to c7b56f8 Compare November 28, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants