-
Notifications
You must be signed in to change notification settings - Fork 4.2k
dependabot manages CA go.mod #8286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Let's merge this first: #8238 |
/area dependency |
Thanks, setting this up is a great idea. I was hoping we could cover k/k as well though. Could we use versions to match latest kubernetes patch version per minor branch? |
IMO let's do that as a follow-up as it'll be a bit trickier to get just right (and may require different config for release branches) wdyt @towca ? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fair enough. Let's merge as is and improve later. /lgtm |
- dependency-name: "github.com/Azure/*" | ||
- dependency-name: "github.com/digitalocean/*" | ||
# Maintain k8s version skew compatibility manually. | ||
- dependency-name: "k8s.io/api" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should include all the possible k/k staging modules instead of just the ones currently used (like we do with replaces in the go.mod). Otherwise if a new staging k/k module is added as CA dependency in the future, we'll treat it differently than all the ones listed here.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a dependabot config for the Cluster Autoscaler go module. The guiding principle here is to manage the set of foundational, core libraries via dependabot, but to continue maintaining (1) Kubernetes client libraries and (2) cloudprovider libraries manually.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: