Skip to content

dependabot manages CA go.mod #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds a dependabot config for the Cluster Autoscaler go module. The guiding principle here is to manage the set of foundational, core libraries via dependabot, but to continue maintaining (1) Kubernetes client libraries and (2) cloudprovider libraries manually.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2025
@jackfrancis
Copy link
Contributor Author

/hold

Let's merge this first: #8238

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2025
@jackfrancis
Copy link
Contributor Author

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 1, 2025
@x13n
Copy link
Member

x13n commented Jul 4, 2025

Thanks, setting this up is a great idea. I was hoping we could cover k/k as well though. Could we use versions to match latest kubernetes patch version per minor branch?

@jackfrancis
Copy link
Contributor Author

Thanks, setting this up is a great idea. I was hoping we could cover k/k as well though. Could we use versions to match latest kubernetes patch version per minor branch?

IMO let's do that as a follow-up as it'll be a bit trickier to get just right (and may require different config for release branches)

wdyt @towca ?

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2025
@x13n
Copy link
Member

x13n commented Jul 10, 2025

IMO let's do that as a follow-up as it'll be a bit trickier to get just right (and may require different config for release branches)

Fair enough. Let's merge as is and improve later.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
- dependency-name: "github.com/Azure/*"
- dependency-name: "github.com/digitalocean/*"
# Maintain k8s version skew compatibility manually.
- dependency-name: "k8s.io/api"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should include all the possible k/k staging modules instead of just the ones currently used (like we do with replaces in the go.mod). Otherwise if a new staging k/k module is added as CA dependency in the future, we'll treat it differently than all the ones listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants