Skip to content

cluster-autoscaler: add ignore-instance-creation-stockout-errors #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsafdsa1
Copy link
Contributor

@dsafdsa1 dsafdsa1 commented Jul 14, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds an option to ignore instance creation stockout errors, which would normally trigger a node group backoff and cause the scale-up to fail. Those nodes are recognized as unregistered and not unready, therefore cluster health is not affected through settings like max-total-unready-percentage and ok-total-unready-count.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add a `ignore-instance-creation-stockout-errors` flag.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dsafdsa1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dsafdsa1
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsafdsa1 dsafdsa1 changed the title cluster-autoscaler: add ignore-instance-creation-errors cluster-autoscaler: add ignore-instance-creation-stockout-errors Jul 17, 2025
@aleksandra-malinowska
Copy link
Contributor

The behaviour introduced in this PR doesn't seem related to any universal autoscaling logic, but rather "treat this VM as if it were in a different state than we (cloud provider) tell you it is because we (cloud provider) also tell you this group is special in this specific way only".

If we want to always ignore the errors from certain instances, why not modify the affected cloud provider(s) to not attach these errors to the instances from this group in the first place? When we fill instances cache, we fetch by the node group anyway, so there's easy access to this information.

I'm open to counter arguments, especially if this is a use-case that can be shared by other cloud providers, or if we use the information about stockouts in another place where we actually want to see it.

Code-wise, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants