Skip to content

Commit fc707dc

Browse files
authored
Merge pull request #5251 from cici37/mapGA
[KEP-3962]Promote MAP to beta in 1.34
2 parents 4c36192 + 562b8fe commit fc707dc

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 3962
22
alpha:
33
approver: "@deads2k"
4+
beta:
5+
approver: "@deads2k"

keps/sig-api-machinery/3962-mutating-admission-policies/README.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -932,15 +932,16 @@ We will test the edge cases mostly in integration test and unit test. We may add
932932

933933
#### Beta
934934

935-
- Gather feedback from developers and surveys
936-
- Complete features A, B, C
935+
- Have proper monitoring for MAP admission plugin
936+
- Fix any blocking issues/bugs surfaced before code freeze
937937
- Additional tests are in Testgrid and linked in KEP
938+
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
939+
- Including all function needed with performance and security in consideration
938940

939941
#### GA
940942

941943
- N examples of real-world usage
942944
- N installs
943-
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
944945
- Allowing time for feedback
945946

946947
**Note:** Generally we also wait at least two releases between beta and
@@ -1196,7 +1197,16 @@ Describe manual testing that was done and the outcomes.
11961197
Longer term, we may want to require automated upgrade/rollback tests, but we
11971198
are missing a bunch of machinery and tooling and can't do that now.
11981199
-->
1199-
Upgrade and rollback will be tested before the feature goes to Beta.
1200+
Upgrade and rollback will be tested manually in a kind:
1201+
1202+
- Enabled feature gate, created a MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding with mutation to add a label to a pod.
1203+
1204+
- Disabled feature gate, restarted apiserver, confirmed that the
1205+
MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding still exist. Added another Pod
1206+
to verify that the mutation would not happen.
1207+
1208+
- Re-enabled the feature gate, restarted apiserver, confirmed that
1209+
the mutation will occur for new incoming pod creation request.
12001210

12011211
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
12021212

@@ -1276,7 +1286,7 @@ Pick one more of these and delete the rest.
12761286
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
12771287
implementation difficulties, etc.).
12781288
-->
1279-
No. We are open to input.
1289+
No.
12801290

12811291
### Dependencies
12821292

@@ -1411,6 +1421,7 @@ details). For now, we leave it here.
14111421
-->
14121422

14131423
###### How does this feature react if the API server and/or etcd is unavailable?
1424+
No change from existing behavior. The feature will serve same as if it's disabled.
14141425

14151426
###### What are other known failure modes?
14161427

keps/sig-api-machinery/3962-mutating-admission-policies/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,17 @@ see-also:
2323
- "/keps/sig-bbb/2345-everyone-gets-a-kep"
2424

2525
# The target maturity stage in the current dev cycle for this KEP.
26-
stage: alpha
26+
stage: beta
2727

2828
# The most recent milestone for which work toward delivery of this KEP has been
2929
# done. This can be the current (upcoming) milestone, if it is being actively
3030
# worked on.
31-
latest-milestone: "v1.32"
31+
latest-milestone: "v1.34"
3232

3333
# The milestone at which this feature was, or is targeted to be, at each stage.
3434
milestone:
3535
alpha: "v1.32"
36+
beta: "v1.34"
3637

3738
# The following PRR answers are required at alpha release
3839
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)