Skip to content

kep-3695-beta update #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2025
+44 −22
Merged

kep-3695-beta update #5346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6e540a5
kep-3695-beta update
guptaNswati May 27, 2025
430351f
Update keps/sig-node/3695-pod-resources-for-dra/README.md
guptaNswati May 27, 2025
72432d5
update milestone version and beta template
guptaNswati Jun 9, 2025
3d1512b
Update approver and kep status
guptaNswati Jun 10, 2025
2402b80
Update to Release Signoff Checklist
guptaNswati Jun 16, 2025
64302a3
Add when Get() returns error
guptaNswati Jun 18, 2025
ae728ef
Address upgrade, resource usage and other related comments
guptaNswati Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-node/3695.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
kep-number: 3695
alpha:
approver: "@johnbelamaric"
beta:
approver: "@johnbelamaric"
9 changes: 7 additions & 2 deletions keps/sig-node/3695-pod-resources-for-dra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,9 @@ These cases will be added in the existing e2e tests:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier in the doc:

  1. Please make sure to check appropriate boxes in the ## Release Signoff Checklist.
  2. Missing links in the integration tests section, see template, and in the e2e section as well, see template. Either of the two is required for beta promotion, and it looks like you had a requirement for e2e during alpha, so I expect those to be completed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please make sure to check appropriate boxes in the ## Release Signoff Checklist.

This was addressed - thank you.

  • Missing links in the integration tests section, see template, and in the e2e section as well, see template. Either of the two is required for beta promotion, and it looks like you had a requirement for e2e during alpha, so I expect those to be completed.

This one still holds. We need links for integration and e2e based on the template in the appropriate section. I believe e2es were added in kubernetes/kubernetes#116846 so you should be able to quickly fill those in. Not sure if there are others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds, I see Francesco mentioned several tests that were added, can we make sure they are explicitly linked in this document?

#### Beta

- [ ] Gather feedback from consumers of the DRA feature.
- [ ] No major bugs reported in the previous cycle.
- [x] Gather feedback from consumers of the DRA feature.
- Integration with DCGM exporter (WIP)
- [x] No major bugs reported in the previous cycle.

#### GA

Expand Down Expand Up @@ -438,6 +439,10 @@ N/A.

- 2024-09-10: KEP Updated to reflect the current state of the implementation.

- Kubernetes 1.27: Alpha version of the KEP.

- Kubernetes 1.34: Beta version of the KEP.

## Drawbacks

## Alternatives
4 changes: 2 additions & 2 deletions keps/sig-node/3695-pod-resources-for-dra/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ see-also:
replaces: []

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
stage: beta

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.27"
latest-milestone: "v1.34"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
Expand Down