Skip to content

KEP-3695: Add updates around e2e tests #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
+17 −1
Merged

KEP-3695: Add updates around e2e tests #5430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c682e
Add updates on e2e test as discussed in PR#5346
guptaNswati Jun 20, 2025
59c48b3
Add code links
guptaNswati Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion keps/sig-node/3695-pod-resources-for-dra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,12 @@ These cases will be added in the existing e2e tests:
- Get API work with DRA and device plugin.
- List API work with DRA and Device plugin.

[Get](https://github.com/kubernetes/kubernetes/pull/116846): [sig-node-kubelet](https://testgrid.k8s.io/sig-node-kubelet?include-filter-by-regex=PodResources), [triage](https://storage.googleapis.com/k8s-triage/index.html?test=PodResources)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR link should be replaced with actual code links to https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go


Other improvements are addressed in:
- https://github.com/kubernetes/kubernetes/pull/132028
- https://github.com/kubernetes/kubernetes/pull/132345
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are fine, since those are no-merged PRs, so when updating this the next time you'll be able to replace these with appropriate links and descriptions like above.


Comment on lines +270 to +273
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, but please doublecheck, is better not to link PRs in the KEP but rather describe the goal these PR implement.
The List fix I mentioned previously is meant to illustrate

  1. the very case we missed
  2. the problem with API underspecification - which we kinda have for Get.

So I'd just remove lines 270-272

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do that once these PRs are merged as @soltysh suggested.

### Graduation Criteria

#### Alpha
Expand All @@ -282,6 +288,13 @@ These cases will be added in the existing e2e tests:

- [ ] Allowing time for feedback (1 year).
- [ ] Risks have been addressed.
- [ ] Add explicit feature enablement/disablement tests, before the feature is turned on by default.
- [ ] Additional test cases are needed to verify Get() behavior in diverse scenarios
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where these addressed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the feature gate one: kubernetes/kubernetes#132827

- Pods with multiple containers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests missing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be left out/last. I'm working on a PR to add it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was to wait for this to be merged before adding other tests kubernetes/kubernetes#132028

- Pods that do not use any exclusive resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, test already present. Stretch goal: add more coverage

- Comparison of List() and Get() on returned pods to validate consistency.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test missing

- Pod exists but container name is invalid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test missing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction: turns out we have an existing test that roughly covers this use case

- Get() is called on terminated pods to validate appropriate error handling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test missing


### Upgrade / Downgrade Strategy

Expand Down Expand Up @@ -334,7 +347,10 @@ The API becomes available again. The API is stateless, so no recovery is needed,

###### Are there any tests for feature enablement/disablement?

e2e test will demonstrate that when the feature gate is disabled, the API returns the appropriate error code. (https://github.com/kubernetes/kubernetes/pull/116846)
This e2e test (https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go#L1169) will demonstrate that when the feature gate is disabled, the API returns the appropriate error code. The explicit on/off tests are scattered across the existing tests:
- https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go#L1115
- https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go#L1820


### Rollout, Upgrade and Rollback Planning

Expand Down