Skip to content

Add SIG-Multicluster reviewers #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

skitt
Copy link
Member

@skitt skitt commented Jul 4, 2025

We're adding a group of reviewers to help with SIG-MC KEP reviews.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from JeremyOT July 4, 2025 09:43
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 4, 2025
@RainbowMango
Copy link
Member

Thanks @skitt

@corentone @jnpacker @ryanzhang-oss All you need to do is file an issue against the kubernetes/org repo.
I'd love to as your sponsor.

@skitt
Copy link
Member Author

skitt commented Jul 4, 2025

@ryanzhang-oss you’re a member of kubernetes-sigs so you can add yourself to kubernetes (I can’t remember the process right now).

@ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss you’re a member of kubernetes-sigs so you can add yourself to kubernetes (I can’t remember the process right now).

kubernetes/org#5702

We're adding a group of reviewers to help with SIG-MC KEP reviews.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt force-pushed the sig-multicluster-reviewers branch from be6160a to 3b9a259 Compare July 30, 2025 09:52
@skitt
Copy link
Member Author

skitt commented Jul 30, 2025

/verify-owners

@lauralorenz
Copy link
Contributor

Something is still up, even though @ryanzhang-oss added himself to the kubernetes org members list in kubernetes/org#5702 and I can see his name in the PR files changed and in the main branch (https://github.com/kubernetes/org/blob/main/config/kubernetes/org.yaml#L797). Per the comments above even after that merged /verify-owners doesn't work on him and his github profile is still only showing him as a member of one kubernetes org, and that is kubernetes-sigs.

Is there some sort of deploy process or something that maybe didn't get kicked and we can kick so that this gets updated? cc @mrbobbytables

@lauralorenz
Copy link
Contributor

@ryanzhang-oss I have learned that there is some sort of banner and/or email invite you have to accept and that is the next step, specifically

They can go to github.com/kubernetes and click accept on the banner that appears
(or from the email they received with the invite)

If you can do that I think we will be good here 👍

@ryanzhang-oss
Copy link
Contributor

the invitation has expired.

@ryanzhang-oss
Copy link
Contributor

how can I get another invitation? maybe @mrbobbytables knows?

@ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss I have learned that there is some sort of banner and/or email invite you have to accept and that is the next step, specifically

They can go to github.com/kubernetes and click accept on the banner that appears
(or from the email they received with the invite)

If you can do that I think we will be good here 👍

I am in

@lauralorenz
Copy link
Contributor

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 12, 2025
@lauralorenz
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9177d4a into kubernetes:master Aug 12, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants