Skip to content

[KEP-5234] Clarify limits on ResourceSlice for mixins #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[KEP-5234] Clarify limits on ResourceSlice for mixins #5455

wants to merge 1 commit into from

Conversation

mortent
Copy link
Member

@mortent mortent commented Jul 19, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jul 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko July 19, 2025 09:51
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Jul 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 19, 2025
@mortent mortent force-pushed the ImproveMixinLimits branch 2 times, most recently from b0a830c to 0c0695e Compare July 19, 2025 10:01
@mortent mortent mentioned this pull request Jul 19, 2025
Open
@mortent mortent force-pushed the ImproveMixinLimits branch from 0c0695e to 39cb508 Compare July 20, 2025 16:15
pohly
pohly approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Approval in SIG Scheduling Jul 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mortent, pohly
Once this PR has been reviewed and has the lgtm label, please assign macsko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helayoty helayoty moved this to Needs Triage in SIG Scheduling Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

Assignees

@pohly pohly

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Scheduling
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mortent @k8s-ci-robot @pohly