-
Notifications
You must be signed in to change notification settings - Fork 317
Optimized apply #2897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized apply #2897
Conversation
> Package errgroup provides synchronization, error propagation, and Context cancelation for groups of goroutines working on subtasks of a common task. errgroup.Group is related to sync.WaitGroup but adds handling of tasks returning errors.
This will take in the output from Compare and apply the calls using already existing forwardingrules.ForwardingRules repository. Calls are paralellised at each stage: delete, patch, create to speed up the whole process. This isn't used yet.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @mmamczur |
/retest E2E errors out on stuff unrelated to this PR:
|
/retest |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/close |
@TortillaZHawaii: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will take in the output from Compare and apply the calls using already existing forwardingrules.ForwardingRules repository. Calls are paralellised at each stage: delete, patch, create to speed up the whole process.
This isn't used yet.
I also vendored in errgroup which is a wrapper for sync.Waitgroup with error handling. More info at golang.org/x/sync/errgroup.