Skip to content

containerd: Don't install crictl and nerdctl by default #17547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

containerd: Don't install crictl and nerdctl by default #17547

merged 3 commits into from
Aug 28, 2025
+261 −931

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 9, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from johngmyers August 9, 2025 06:25
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus August 9, 2025 06:25
@hakman hakman force-pushed the no-crictl-nerdctl branch 2 times, most recently from 3780def to 16c84d4 Compare August 9, 2025 10:30
@hakman
Copy link
Member Author

hakman commented Aug 9, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
@hakman hakman force-pushed the no-crictl-nerdctl branch from 16c84d4 to 4781362 Compare August 10, 2025 19:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
@hakman
Copy link
Member Author

hakman commented Aug 10, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2025
@justinsb
Copy link
Member

LGTM. I assume this is to speed up bring-up? Do we need to discuss in office hours or do we think this is good as-is?

As this has a merge conflict so it won't "just merge":

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2025
@hakman hakman force-pushed the no-crictl-nerdctl branch from 4781362 to e8419e2 Compare August 28, 2025 15:58
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 28, 2025
@hakman
Copy link
Member Author

hakman commented Aug 28, 2025

/cc @ameukam @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from ameukam August 28, 2025 16:09
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet August 28, 2025 16:09
@ameukam
Copy link
Member

ameukam commented Aug 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 665265a into kubernetes:master Aug 28, 2025
27 checks passed
@hakman hakman deleted the no-crictl-nerdctl branch August 28, 2025 20:09
@ameukam
Copy link
Member

ameukam commented Sep 3, 2025

Looks like we are failing on a SIG Node test: https://testgrid.k8s.io/kops-gce#kops-gce-latest ?

@hakman
Copy link
Member Author

hakman commented Sep 3, 2025

Looks like we are failing on a SIG Node test: https://testgrid.k8s.io/kops-gce#kops-gce-latest ?

We will just skip it, tests with external dependencies should not run by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@justinsb justinsb

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @justinsb @k8s-ci-robot @ameukam