Skip to content

ginkgo: randomize all tests #134756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ginkgo: randomize all tests #134756

wants to merge 1 commit into from
+3 −0

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Oct 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We want to randomize all tests because it exposes unintentional dependencies between tests. They now run truly in a random order. Previously only the order of the outer Describe containers was randomized.

Which issue(s) this PR is related to:

onsi/ginkgo#1599 (comment)
https://kubernetes.slack.com/archives/C09QZ4DQB/p1761064993910909

Special notes for your reviewer:

/hold

Let's merge on Friday evening to see other the weekend whether it causes issues.

Does this PR introduce a user-facing change?

NONE

/assign @BenTheElder @aojea

@pohly
ginkgo: randomize all tests
c80c10e 
We want to randomize all tests because it exposes unintentional dependencies
between tests. They now run truly in a random order. Previously only the
order of the outer `Describe` containers was randomized.
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 21, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 21, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2025
@dims
Copy link
Member

dims commented Oct 21, 2025

/approve
/lgtm
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f7a33ffc05227924334fc356d690f44b04b7f8a

BenTheElder
BenTheElder reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor Author

pohly commented Oct 22, 2025

/test pull-kubernetes-unit

#134771

Let's also try some other jobs:
/test pull-kubernetes-kind-alpha-beta-enabled pull-kubernetes-kind-alpha-beta-features pull-kubernetes-conformance-kind-ipv6-parallel pull-kubernetes-conformance-kind-ga-only pull-kubernetes-audit-kind-conformance

@pohly
Copy link
Contributor Author

pohly commented Oct 22, 2025

@onsi pointed out that "Random Seed: 1761053792 - will randomize all specs" really does reflect the current --randomize-all. It's just enabled via hard-coding in our E2E framework:

kubernetes/test/e2e/framework/test_context.go

Lines 401 to 402 in e1b996a

// Randomize specs as well as suites
suiteConfig.RandomizeAllSpecs = true

Therefore we don't need this command line change. Or should we apply it for clarity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@BenTheElder BenTheElder

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pohly @k8s-ci-robot @dims @BenTheElder @aojea