-
Notifications
You must be signed in to change notification settings - Fork 5k
Add --disable-coredns-log
flag
#20992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --disable-coredns-log
flag
#20992
Conversation
|
Welcome @sugymt! |
Hi @sugymt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
@@ -957,7 +957,7 @@ func addCoreDNSEntry(runner command.Runner, name, ip string, cc config.ClusterCo | |||
} | |||
|
|||
if cc.DisableCoreDNSLog { | |||
sed = fmt.Sprintf("%s -e '/^ log$/d'", sed) | |||
sed = fmt.Sprintf("%s -e '/^ log *$/d'", sed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be easier to review if you squash this fix into the commit that added this change and force push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've pushed it.
6fc84cf
to
2921937
Compare
/ok-to-test |
@sugymt I am curious what is the use case for this ? like what made you think about disabling it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sugymt would u plz put in the PR description "the logs of coredns" before/after this PR ?
kvm2 driver with docker runtime
Times for minikube start: 50.9s 52.6s 52.9s 52.5s 52.7s Times for minikube ingress: 16.1s 15.6s 16.1s 16.6s 15.6s docker driver with docker runtime
Times for minikube start: 22.5s 25.0s 23.3s 23.5s 24.0s Times for minikube ingress: 13.3s 13.3s 13.3s 13.3s 12.4s docker driver with containerd runtime
Times for minikube start: 24.8s 24.2s 26.1s 22.0s 24.7s Times for minikube ingress: 23.8s 23.3s 22.8s 23.8s 23.8s |
@medyagh I've added a description. Could you please check the issue to see what led me to need this option? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sugymt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #19757
Adds the
--disable-coredns-log
option to cluster startup. When enabled, this option removes thelog
plugin from the CoreDNS ConfigMap, preventing query logs from being output to the Pod logs.before (default)
after (--disable-coredns-log)