Improve addons list table design
#21151
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pavansaikrishna78 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @pavansaikrishna78. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
Thanks for the preview. I don't think this provide good experience. Red usually means the something is broken, but nothing is broken with addon that is not installed. We should make it easy to see these states
And we don't want to show the entire raw in color, coloring only the status would be cleaner. Check how systemd commands show status of units, we can learn from them since lot of users already know the systemd commands and expect similar look. Also see https://unicode.org/emoji/charts/full-emoji-list.html |
|
I see that we already use ✅ - no need to add more colors. Maybe only the status field. |
|
The current issue with the addons list command is showing 2 much info:
Adding colors will not make the commands better. |
|
@pavansaikrishna78 do we have an issue for this change? it will better to start such changes with an issue explaining what you are trying to solve, and add design mockups to the issue is instead of working on a change that may be in the wrong direction. |
|
@pavansaikrishna78: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
medyagh
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
@pavansaikrishna78 please update the pr and commit message to describe the actual change and update the screenshot to current version. |
|
@pavansaikrishna78 but instead of light blue just have normal white color ? |
| @@ -127,11 +127,22 @@ var printAddonsList = func(cc *config.ClusterConfig, printDocs bool) { | |||
| if docs == "" { | |||
| docs = "n/a" | |||
| } | |||
| const ( | |||
There was a problem hiding this comment.
if these contants are needed, consider move them to "constants" package so all other future color-needed be using that
and also in "minikube profile list" if the cluster is "running" it should be green and if it is Error state it should Red
There was a problem hiding this comment.
We should have package for ui colors, to encourage people to use the same styles everywhere. The color should have more meaningful names like disabled, enabled, default, ...
|
/retitle Improve |
k8s-ci-robot
changed the title
addons list table design
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
…m v0.17.2 to v0.17.3 (kubernetes#21225)
* add update all go script * add update all make target * add update all make target * standardize the component name for look up * standardize amd amd component name * rename all hack update go code to match component name to standardize * delete extra folder * update makefile with new standard filenames * update component name amd * fix amd gpu name * skip amd for now till broken * fix cilium helm update * standard name for cloud spanner emulator * standard crio name * set max to 100 * delete old folder * skip docsy for update all * return error if fail to apply * docsy versoin * update files with go-github * update file names * move all make targets to same location * standard name for golang comp * skip istio addon * skip kicbase version since it is not related * skip kubeadm constant too * skip kubernetes version too * run components that dont support before/after * update kubeadm constant * skip kubeadm constant on non linux * add kubernetes_versions_list to not support before/after * list preload version as one of the internal jobs * list preload version as one of the internal jobs * simpllify the code * use log for printing * add boiler plates * add gh workflow
…s#21212) * remove un-needed gomod replaces * add a make target gomodtidy * update docs on using gomodtidy * add automation to run go mod tidy on every push * update contributing docs to be more helpful * install gopogh if it is not installed in html_report * addres PR reviews * update docs headings
…21215) * remove omitnew line * add new option to hide after spin * refactor to use new return hideAfterSpin * add new line by default only when not spinining and delegate spinner newline to spinner code * add new func for ouptputing with spinner and pass fdwriter directly to the spininer func * fix unit test * fix lint for krunkit * add comment and context * use different spinning progress bar for sub steps * make func private * making more spinning icons * integration test dont expect sub steps to be visible * fix unit test and comment why * change sub step spining icon not to be a progressbar * pass the filewriter to the spinner library for the spinning steps
* Kicbase/ISO: Update docker from 28.3.2 to 28.3.3 * Updating kicbase image to v0.0.47-1754427148-21248
getWindowsVolumeNameCmd uses the deprecated wmic.exe. See https://learn.microsoft.com/en-us/windows/win32/wmisdk/wmic for details. Replace the implementation with a call to the Powershell equivalent. Look in path and system environment vars to locate Powershell. Improve Powershell discovery
…es#20959) * Add support for --device=nvidia.com/gpu=all * Add "nvidia.com" to valid options for gpus flag in TestValidateGPUs.
…bernetes#21263) * do not show github issue in exist twice if kubeadm * Reset the flag for each test case
Running the function tests creates a licenses directory and checks out
the "github.com/hooklift/iso9660" module, which imports
"github.com/c4milo/gotoolkit".
% git status
...
Untracked files:
(use "git add <file>..." to include in what will be committed)
test/integration/licenses/
At this point running go mod tidy will add the gotoolkit module:
% go mod tidy --diff
diff current/go.mod tidy/go.mod
--- current/go.mod
+++ tidy/go.mod
@@ -13,6 +13,7 @@
github.com/Xuanwo/go-locale v1.1.3
github.com/blang/semver/v4 v4.0.0
github.com/briandowns/spinner v1.23.2
+ github.com/c4milo/gotoolkit v0.0.0-20190525173301-67483a18c17a
github.com/cenkalti/backoff/v4 v4.3.0
github.com/cheggaaa/pb/v3 v3.1.7
github.com/cloudevents/sdk-go/v2 v2.16.0
...
"github.com/hooklift/iso9660" does not have a go.mod file, so `go mod
tidy` treats is as part of the main module and update go.mod.
We should find a better place to check out the licenses, maybe a test
temporary directory, but let's start with quick fix: ignore the license
directory, and include it in `make clean`.
Like other editor files this allow local configuration without polluting the source with specific editor configuration.
Move all files and packages which are not a driver to the drivers/common
package. This helps to understand the structure of the code.
While moving, move the iso_test.iso into testdata/test.iso to separate
code and test data.
While fixing the test iso path fix few bugs in the tests using wrong iso
path. The test failed because the iso path was wrong instead of issue
with source or destination path.
New directory structure:
% tree -L1 pkg/drivers
pkg/drivers
├── common
├── hyperkit
├── kic
├── krunkit
├── kvm
├── none
├── qemu
├── ssh
└── vfkit
…etes#21265) Add special case handlers in get_version.go for components that require non-standard version extraction methods: - docsy: Extract git submodule commit hash - kubernetes: Read DefaultKubernetesVersion from constants - kubeadm-constants: Parse latest version from kubeadm images map - kubernetes-versions-list: Count and summarize supported versions - site-node: Use existing node version extraction from netlify.toml Remove all entries from noVersionCheck map in update_all.go to enable before/after version comparison for these components. This allows 'DEP=component make get-dependency-version' commands to work for all components, improving the auto-updater workflow.
…rnetes#21174) * docker: update template for docker.service * wait for docker * fix unit test
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
If status is enabled then the whole row green else the whole row red
