fix missing project id and delete deprecated LegacyIsMasterNode function #3653
+50
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
upodroid
force-pushed
the
fix-missing-project-id
branch
from
a93386a to
6193b1d
Compare
|
/retest |
upodroid
force-pushed
the
fix-missing-project-id
branch
from
6193b1d to
f917182
Compare
k8s-ci-robot
added
size/L
upodroid
force-pushed
the
fix-missing-project-id
branch
from
f917182 to
38c704a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Scale jobs using kops are failing because the GCP project id is not explicitly set. I changed it to read node providerID set by the cloud controller manager.
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-kops-gce-5000-ipalias-using-cl2/1980979471863255040
I also cleaned up a function deprecated in k8s 1.19
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: