-
Notifications
You must be signed in to change notification settings - Fork 526
Add tests for specs/template.go file #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TatianaSelezneva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @TatianaSelezneva. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
55b7a32 to
33f96d8
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We are missing unit tests for krel obs and this PR attempts to improve coverage
Relevant card from the project board: #3168
Which issue(s) this PR fixes:
It improves unit test coverage for the krel obs
Special notes for your reviewer:
PR includes tests for specs/template.go. It is incremental improvement for obs package tests. We need to add tests to 'archive.go' to complete the suite.
Does this PR introduce a user-facing change?