-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Headlamp image-pushing job #35028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Headlamp image-pushing job #35028
Conversation
Hi @joaquimrocha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one issue with the bits from sig-release
[sig release releases kubernetes/kubernetes and has some tooling of their own which gets built] |
/ok-to-test |
I am: https://github.com/kubernetes/org/blob/be9f7826308610c09788f1537a2f0a6d796ea043/config/kubernetes-sigs/org.yaml#L462 |
cbfb932
to
41903fc
Compare
Thank you again @BenTheElder ! I have updated the job with the data more related to headlamp as you suggested. |
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
41903fc
to
c43c103
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joaquimrocha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I had to add a new dashboard config for sig-ui. Took the liberty to choose the owners for it and add myself to the list, since I am likely the only one who needs this ATM. cc/ @floreks , @maciaszczykm |
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
c43c103
to
ade8de6
Compare
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing
|
# See the OWNERS docs at https://go.k8s.io/owners | ||
|
||
reviewers: | ||
- florek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here and below, should be @floreks, right?
reviewers: | ||
- florek | ||
- maciaszczykm | ||
- joaquimrocha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the bot comment / my previous comment, we need to make you a member of this org to be in OWNERS files. github.com/kubernetes/org repo manages this, there's an issue type or you can send a PR directly. I'm guessing you are only in kubernetes-sigs currently, but IMHO there's no reason to not be in both.
I am chatting with the SIG UI folks. I will update the PR afterwards. |
This is for the Headlamp image build.
Basing this in other existing jobs. Hope this works.