Skip to content

Add Headlamp image-pushing job #35028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joaquimrocha
Copy link
Contributor

This is for the Headlamp image build.
Basing this in other existing jobs. Hope this works.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from BenTheElder and dims June 24, 2025 21:44
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 24, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue with the bits from sig-release

@BenTheElder
Copy link
Member

[sig release releases kubernetes/kubernetes and has some tooling of their own which gets built]

@BenTheElder
Copy link
Member

/ok-to-test
Are you not a Kubernetes org member? You probably should be, https://github.com/kubernetes/org controls that

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2025
@joaquimrocha
Copy link
Contributor Author

@joaquimrocha joaquimrocha force-pushed the add-headlamp-build-trigger branch from cbfb932 to 41903fc Compare June 25, 2025 08:02
@joaquimrocha
Copy link
Contributor Author

Thank you again @BenTheElder ! I have updated the job with the data more related to headlamp as you suggested.
BTW, this PR would also help our releases a great deal: #34998

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha joaquimrocha force-pushed the add-headlamp-build-trigger branch from 41903fc to c43c103 Compare June 25, 2025 08:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joaquimrocha
Once this PR has been reviewed and has the lgtm label, please assign michelle192837 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/testgrid do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jun 25, 2025
@joaquimrocha
Copy link
Contributor Author

I had to add a new dashboard config for sig-ui. Took the liberty to choose the owners for it and add myself to the list, since I am likely the only one who needs this ATM.

cc/ @floreks , @maciaszczykm

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha joaquimrocha force-pushed the add-headlamp-build-trigger branch from c43c103 to ade8de6 Compare June 25, 2025 08:28
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • florek
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • config/testgrids/kubernetes/sig-ui/OWNERS
  • joaquimrocha
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • config/testgrids/kubernetes/sig-ui/OWNERS

# See the OWNERS docs at https://go.k8s.io/owners

reviewers:
- florek
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here and below, should be @floreks, right?

reviewers:
- florek
- maciaszczykm
- joaquimrocha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the bot comment / my previous comment, we need to make you a member of this org to be in OWNERS files. github.com/kubernetes/org repo manages this, there's an issue type or you can send a PR directly. I'm guessing you are only in kubernetes-sigs currently, but IMHO there's no reason to not be in both.

@joaquimrocha
Copy link
Contributor Author

I am chatting with the SIG UI folks. I will update the PR afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants