node: add podresources API presubmit and disambiguate pod level resources presubmit

[ffromani]

Up until now, we used "podresources" ambiguosly: it historically referred to podresources API, but we started to use for pod-level resources tests. This PR disambiguate the term, but most notably adds a presubmit job which targets explicitly the podresources API tests, which previously where running incidentally in other lanes.

xref: kubernetes/enhancements#5346 (comment)
xref: kubernetes/kubernetes#132345

[ffromani]

/cc @ndixita @tallclair @guptaNswati

[k8s-ci-robot]

@ffromani: GitHub didn't allow me to request PR reviews from the following users: guptaNswati.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ndixita @tallclair @guptaNswati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ffromani]

ping for review, it's important for KEP 3695

[elieserpereiracentr]

I think might be important to introduce new jobs using kubetest2 since kubetest its already being deprecated

[SergeyKanzhelev]

+1 to this. But not blocking from my POV

[ffromani]

fair enough, I can update

[guptaNswati]

Nice to have pull-kubernetes-node-kubelet-serial-podresourcesapi Thank you @ffromani

[SergeyKanzhelev]

is this image the reason we need a separate lane and cannot run them as part of other Serial?

[ffromani]

we only need a filter, be it focus or label-filter which captures the podresourcesapi tests explicitly. Everything else is incidental and I can change as needed

[SergeyKanzhelev]

perhaps running as part of serial would be OK than? So we avoid an extra test lane

[ffromani]

That's surely a tradeoff we can explore. I'm fixing this PR as suggested by review comments, then we can evaluate another approach.
From CI costs perspective my intuition is that a targeted lane is less costly than running a full lenghtier lane only because we are interested in a subset of tests, but I'm totally open to discuss it.

[ffromani]

@SergeyKanzhelev I'm not strongly pushing for a separate lane for podresources API. These are the reasons why I think it helps:

1. being podresources API a sig-node feature, it feels natural to have its own separate lane, but most notably
2. this PRs removes two footguns:
   a. disambiguate the pod level resources lane (what does "podresources" mean?)
   b. provides a clear entry point for each feature to be exercised; it is counter intuitive to be required to run the full serial suite for the podresources tests.

that said: I'm open to just fix the serial suite. I guess the driver here is to keep the number of lanes manageable, right? The only problem I see is to document somehow that to run podresources tests we need to run the full serial suite, otherwise this fact becomes tribal knowledge which gets lost easily.

[ffromani]

still pending: move to kubetest2 (on it)

[ffromani]

it seems we can just run these two lanes to exercise the podresources API tests:

pull-kubernetes-node-kubelet-serial-containerd
pull-kubernetes-node-kubelet-serial-containerd-kubetest2

verifying

[ffromani]

not great, it seems the serial lanes are experiencing some bitrot? Maybe we "just" need to bump the timeout?
https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=132940

[guptaNswati]

not great, it seems the serial lanes are experiencing some bitrot? Maybe we "just" need to bump the timeout? https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=132940

Found the issue in CI infra with instance type #35205

Now the instance is coming up but tests are still skipped. @ffromani we need to look more deeply and need time to do all the fixes. Is it okay if we don't block this kubernetes/kubernetes#132940

[SergeyKanzhelev]

/approve
/lgtm

let's use it temporarily as other serial lanes a in a bad shape and we need a KEP to be merged

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-node/OWNERS [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@ffromani: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Up until now, we used "podresources" ambiguosly: it historically referred to podresources API, but we started to use for pod-level resources tests. This PR disambiguate the term, but most notably adds a presubmit job which targets explicitly the podresources API tests, which previously where running incidentally in other lanes.

xref: kubernetes/enhancements#5346 (comment)
xref: kubernetes/kubernetes#132345

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.