Skip to content

Create views with schemas #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Create views with schemas #651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da29876
add schema support for view create/drop
argmonster Oct 26, 2022
46cd4c2
make the linter happy
argmonster Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions sqlalchemy_utils/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,40 @@


class CreateView(DDLElement):
def __init__(self, name, selectable, materialized=False):
def __init__(self, name, selectable, materialized=False, schema=None):
self.name = name
self.selectable = selectable
self.materialized = materialized
self.schema = schema


@compiler.compiles(CreateView)
def compile_create_materialized_view(element, compiler, **kw):
return 'CREATE {}VIEW {} AS {}'.format(
return 'CREATE {}VIEW {}{} AS {}'.format(
'MATERIALIZED ' if element.materialized else '',
f'{compiler.dialect.identifier_preparer.quote(element.schema)}.'
if element.schema
else '',
compiler.dialect.identifier_preparer.quote(element.name),
compiler.sql_compiler.process(element.selectable, literal_binds=True),
)


class DropView(DDLElement):
def __init__(self, name, materialized=False, cascade=True):
def __init__(self, name, materialized=False, cascade=True, schema=None):
self.name = name
self.materialized = materialized
self.cascade = cascade
self.schema = schema


@compiler.compiles(DropView)
def compile_drop_materialized_view(element, compiler, **kw):
return 'DROP {}VIEW IF EXISTS {} {}'.format(
return 'DROP {}VIEW IF EXISTS {}{} {}'.format(
'MATERIALIZED ' if element.materialized else '',
f'{compiler.dialect.identifier_preparer.quote(element.schema)}.'
if element.schema
else '',
compiler.dialect.identifier_preparer.quote(element.name),
'CASCADE' if element.cascade else ''
)
Expand Down Expand Up @@ -103,7 +111,7 @@ def create_materialized_view(
sa.event.listen(
metadata,
'after_create',
CreateView(name, selectable, materialized=True)
CreateView(name, selectable, materialized=True, schema=metadata.schema)
)

@sa.event.listens_for(metadata, 'after_create')
Expand All @@ -114,7 +122,7 @@ def create_indexes(target, connection, **kw):
sa.event.listen(
metadata,
'before_drop',
DropView(name, materialized=True)
DropView(name, materialized=True, schema=metadata.schema)
)
return table

Expand Down Expand Up @@ -163,7 +171,11 @@ def create_view(
metadata=None
)

sa.event.listen(metadata, 'after_create', CreateView(name, selectable))
sa.event.listen(
metadata,
'after_create',
CreateView(name, selectable, schema=metadata.schema)
)

@sa.event.listens_for(metadata, 'after_create')
def create_indexes(target, connection, **kw):
Expand All @@ -173,7 +185,7 @@ def create_indexes(target, connection, **kw):
sa.event.listen(
metadata,
'before_drop',
DropView(name, cascade=cascade_on_drop)
DropView(name, cascade=cascade_on_drop, schema=metadata.schema)
)
return table

Expand Down