feat(l1): periodically check if there is a newer release available #5322
Conversation
Lines of code reportTotal lines added: Detailed view |
cmd/ethrex/Cargo.toml
Outdated
| thiserror.workspace = true | ||
| itertools = "0.14.0" | ||
| url.workspace = true | ||
| semver = "1.0.27" |
There was a problem hiding this comment.
We're not following semver right now, so this is probably not the right tool to use.
I would just use a simple inequality check against latest.
There was a problem hiding this comment.
But wouldn't that be bothersome if the user is running a newer version instead of the latest? Like a release candidate on in-development version?
There was a problem hiding this comment.
In that case, I would still not use a crate that assumes semver in a package that explicitly opts out of semver. A simple function that splits and parses integers and checks whether any is less than the latest version's one should suffice.
There was a problem hiding this comment.
Okay, I wanted to avoid implementing a manual comparison as we already have semver as a dependency on most of our lock files that provides it, but we can add it
There was a problem hiding this comment.
Added manual version comparison: f637f4e
cmd/ethrex/ethrex.rs
Outdated
| } | ||
| let client = reqwest::Client::new(); | ||
| let response = client | ||
| .get("https://api.github.com/repos/lambdaclass/ethrex/releases/latest") |
There was a problem hiding this comment.
I would put the URL in a constant in a common place
Motivation
Periodically checking and informing the user if there is a newer version of ethrex available
Description