Skip to content

feat(l1)!: compress some tables #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 2, 2025
Merged

feat(l1)!: compress some tables #5323

merged 12 commits into from
Dec 2, 2025

Conversation

@iovoid
Copy link
Contributor

@iovoid iovoid commented Nov 13, 2025 •
edited
Loading

Motivation

We disabled compression for all tables, but some tables with less but larger elements could benefit and bring small space savings.

Description

This PR enables compression for codes and other, smaller, compressible tables.

@iovoid iovoid requested a review from a team as a code owner November 13, 2025 17:27
@iovoid iovoid marked this pull request as draft November 13, 2025 17:27
@github-actions github-actions bot added L1 Ethereum client performance Block execution throughput and performance in general labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Lines of code report

Total lines added: 11
Total lines removed: 0
Total lines changed: 11

Detailed view 
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1736  | +11  |
+-------------------------------------------+-------+------+

@iovoid iovoid changed the title perf(l1): compress codes perf(l1)!: compress some tables Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 61.402 ± 1.122 60.045 63.406 1.00
head 62.702 ± 0.493 61.909 63.651 1.02 ± 0.02

@iovoid iovoid changed the title perf(l1)!: compress some tables feat(l1)!: compress some tables Nov 13, 2025
@github-actions github-actions bot removed performance Block execution throughput and performance in general L1 Ethereum client labels Nov 13, 2025
pablodeymo
pablodeymo reviewed Dec 1, 2025
View reviewed changes
@iovoid @pablodeymo
remove extra newline
8eb1388 
Co-authored-by: Pablo Deymonnaz <pdeymon@fi.uba.ar>
@iovoid iovoid marked this pull request as ready for review December 2, 2025 19:14
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Dec 2, 2025
@iovoid iovoid enabled auto-merge December 2, 2025 19:28
@iovoid iovoid added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 9feefd2 Dec 2, 2025
42 checks passed
@iovoid iovoid deleted the compress_codes branch December 2, 2025 20:26
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Dec 2, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in ethrex_performance Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@iovoid iovoid

Labels

None yet

Projects

ethrex_l1
Status: Done
ethrex_performance
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iovoid @pablodeymo @MegaRedHand @jrchatruc