Skip to content

Conversation

@mdrxy
Copy link
Member

@mdrxy mdrxy commented Nov 13, 2025

WIP

Based largely on the excellent foundational work done by @emhagman in #1077

https://googleapis.github.io/python-genai/index.html

Closes #853
Closes #1212

@mdrxy mdrxy changed the title feat(genai): big kahuna migration to google-genai feat(genai): migration to google-genai Nov 13, 2025
@mdrxy mdrxy changed the title feat(genai): migration to google-genai feat!(genai): migration to google-genai Nov 13, 2025
@mdrxy mdrxy changed the title feat!(genai): migration to google-genai feat(genai)!: migration to google-genai Nov 13, 2025
@oDaiSuno
Copy link

oDaiSuno commented Nov 27, 2025

Regarding the code for _parse_response_candidate in chat_models.py, I believe we should remove the validation for None values in the content field. According to the latest Gemini API recommendations, the 3pro model now enforces the inclusion of a thought signature alongside function call.

https://ai.google.dev/gemini-api/docs/thinking?authuser=1&hl=zh-cn#signatures

    # Add function call signatures to content only if there's already other content
    # This preserves backward compatibility where content is "" for
    # function-only responses
    if function_call_signatures:
        for sig_block in function_call_signatures:
            content = _append_to_content(content, sig_block)

@mdrxy
Copy link
Member Author

mdrxy commented Nov 27, 2025

@oDaiSuno yep, haven't rebased this on the latest changes in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Proxy support (parity with langchain-openai) Migrate to new higher-level google-genai SDK?

3 participants