Skip to content

#923 fix for IndexOutOfBoundsException #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

#923 fix for IndexOutOfBoundsException #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...in4j-embeddings/src/main/java/dev/langchain4j/model/embedding/onnx/OnnxBertBiEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ private static float[] meanPool(float[][] vectors) {
}

private float[] weightedAverage(List<float[]> embeddings, List<Integer> weights) {
if (embeddings.isEmpty()) {
throw new RuntimeException("Embeddings list cannot be empty");
Copy link

@kpavlov kpavlov Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest using more specific IllegalArgumentException?

Copy link

@kpavlov kpavlov Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Embeddings list cannot be empty");
throw new IllegalArgumentException("Embeddings list cannot be empty");

}

if (embeddings.size() == 1) {
return embeddings.get(0);
}
Expand Down