Issues3073:support ToolProvider automatically wired into the AI Service if available in the application contex #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available in the application contex
dliubarskyi
reviewed
Jul 2, 2025
There was a problem hiding this comment.
@zzx1314 thanks a lot!
Please improve the test, then this can be merged
| .withConfiguration(AutoConfigurations.of(AiServicesAutoConfig.class)); | ||
|
|
||
| @Test | ||
| void should_fail_to_create_AI_service_when_conflicting_chat_models_are_found() { |
There was a problem hiding this comment.
This is a very brittle test and it also has a wrong name.
Please change the test to not use reflection, but use a real tool instead.
For example, TestMcpToolProvider could provide an actual tool which does somehting (e.g., returns an amount by a unique transaction ID). When asked AI Service to provide an amout for this specific transaction, check that LLM returns correct (hardcoded) value.
There was a problem hiding this comment.
@zzx1314 please follow @dliubarskyi , wait for your feature.
|
Hi @zzx1314, do you plan to finalize this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3073
Change
support ToolProvider automatically wired into the AI Service if available in the application contex
General checklist