WIP: Updating library for DBAL 4 changes. #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
TomHAnderson
requested changes
Dec 13, 2025
| } | ||
|
|
||
| /** | ||
| * @throws RuntimeException |
Contributor
There was a problem hiding this comment.
These two functions are too close. Add comments to each function to describe the use of each.
src/Schema/Table.php
Outdated
| * @return Blueprint|null | ||
| */ | ||
| public function primary($columns, $indexName = false): ?Blueprint | ||
| public function primary($columns, ?string $indexName = null, bool $isClustered = false): ?Blueprint |
Contributor
There was a problem hiding this comment.
never use ?type; use string|null
src/Schema/Table.php
Outdated
| { | ||
| $columns = is_array($columns) ? $columns : [$columns]; | ||
|
|
||
| if (count($columns) === 0) { |
Contributor
There was a problem hiding this comment.
use a bang operator (and right-space-pad it) instead of equality for code brevity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains updates to laravel-doctrine/migrations that allow it to work with the latest version of doctrine/migrations (3.9.5) and more importantly DBAL4.
This is tagged as Work In Progress to give some time for review of the changes and to make any necessary changes to the Upgrade.md document.
These changes have been tested against a net new Laravel 12 project, but not been attempted in an existing project being updated as of yet.
Since the Laravel Doctrine website is outdated in setup information, it might make sense to include more implementation/configuration details in the Github Readme or Wiki?