-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[12.x] Introduce WithCachedRoutes testing trait
#57623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
773ee89
with cached routes
cosmastech cd4000c
clean up
cosmastech e1ac69c
clean up
cosmastech 0490096
try to guess how Taylor would format it
cosmastech f473558
compile to array
cosmastech b606fdd
Update WithCachedRoutes.php
cosmastech 45bc684
I think this is better
cosmastech 33a4800
comments
cosmastech 3c84de0
lighter check first
cosmastech d5024c2
static
cosmastech ea9a089
formatting
taylorotwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Foundation\Testing; | ||
|
|
||
| class CachedState | ||
| { | ||
| public static array $cachedRoutes; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Foundation\Testing; | ||
|
|
||
| use Illuminate\Foundation\Application; | ||
| use Illuminate\Foundation\Support\Providers\RouteServiceProvider; | ||
|
|
||
| trait WithCachedRoutes | ||
| { | ||
| /** | ||
| * After creating the routes once, we can cache them for the remaining tests. | ||
| * | ||
| * @return void | ||
| */ | ||
| protected function setUpWithCachedRoutes(): void | ||
| { | ||
| // If we haven't stored the cached routes yet, then let's store them | ||
| // once so we can use them in the remaining tests. | ||
| if ((CachedState::$cachedRoutes ?? null) === null) { | ||
| $routes = $this->app['router']->getRoutes(); | ||
| $routes->refreshNameLookups(); | ||
| $routes->refreshActionLookups(); | ||
| CachedState::$cachedRoutes = $routes->compile(); | ||
| } | ||
|
|
||
| $this->markRoutesCached($this->app); | ||
| } | ||
|
|
||
| /** | ||
| * Reset the route service provider so it's not defaulting to loading cached routes. | ||
| * Helpful if some of the tests in the suite apply this trait while others do not. | ||
| * | ||
| * @return void | ||
| */ | ||
| protected function tearDownWithCachedRoutes(): void | ||
| { | ||
| RouteServiceProvider::loadCachedRoutesUsing(null); | ||
| } | ||
|
|
||
| /** | ||
| * Inform the container to treat routes as cached. | ||
| */ | ||
| protected function markRoutesCached(Application $app): void | ||
| { | ||
| $app->instance('routes.cached', true); | ||
|
|
||
| RouteServiceProvider::loadCachedRoutesUsing( | ||
| static fn () => app('router')->setCompiledRoutes(CachedState::$cachedRoutes) | ||
| ); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this check can and should be cached (regardless if this PR is accepted)
Unless there's a reason to expect that during a run (either with the traditional PHP model or using Octane) this file would be deleted, we are repeatedly performing a file_exists check.