toEnglishFormat() / add number conversion helper #57669
Conversation
….com/farad-tech/laravel-framework into feature/add-number-conversion-helper
| * Converting Persian/Arabic digits to English | ||
| * @param mixed $value | ||
| * @return string | ||
| */ | ||
| function to_english_numbers($value): string |
There was a problem hiding this comment.
How would I know that this is specific to Persian/Arabic digits from the helper name alone? And these are not English, the are Arabic numbers, just not Eastern Arabic numerals, but Western Arabic numerals.
And what about other numbering systems?
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
| if (! function_exists('to_english_numbers')) { | ||
| /** | ||
| * Converting Persian/Arabic digits to English | ||
| * @param mixed $value |
There was a problem hiding this comment.
Is this really mixed? Shouldn't this be
| * @param mixed $value | |
| * @param string $value |
?
There was a problem hiding this comment.
I created this function to Number helper so we don't need to repeat it here. I'll remove that from helper.php
| /** | ||
| * Converting Persian/Arabic digits to English | ||
| * @param mixed $value | ||
| * @return string |
There was a problem hiding this comment.
After using Number::toEnglishFormat() (#57669 (comment)), the return type has to be adjusted as well:
| * @return string | |
| * @return int|float |
| /** | ||
| * Converting Persian/Arabic digits to English | ||
| * @param mixed $value | ||
| * @return bool|float|int |
| use Illuminate\Support\Fluent; | ||
| use Illuminate\Support\HigherOrderTapProxy; |
There was a problem hiding this comment.
Oh, and you have to import the Number class 😉 (#57669 (comment))
https://github.com/laravel/framework/actions/runs/19084359967/job/54521096356?pr=57669
| use Illuminate\Support\Fluent; | |
| use Illuminate\Support\Number; | |
| use Illuminate\Support\HigherOrderTapProxy; |
| $numberFormatter = new NumberFormatter('ar-u-nu-latn', NumberFormatter::DECIMAL); | ||
| return $numberFormatter->parse($value); |
There was a problem hiding this comment.
This could even use internal methods:
| $numberFormatter = new NumberFormatter('ar-u-nu-latn', NumberFormatter::DECIMAL); | |
| return $numberFormatter->parse($value); | |
| return self::parse($value, locale: 'ar-u-nu-latn'); |
2 participants
Many Laravel developers working with Persian or Arabic inputs often need to normalize user-entered numeric values (for example, phone numbers or amounts) before validation or database storage. Having this as a built-in helper improves developer experience and prevents code duplication across projects.
All tests are included and passing.