Full-text improvements #947
Merged
+107
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeiKatz
reviewed
Oct 9, 2025
src/Engines/DatabaseEngine.php
Outdated
| return $query->where(function ($query) use ($builder, $columns, $prefixColumns, $fullTextColumns) { | ||
| $connectionType = $builder->model->getConnection()->getDriverName(); | ||
| [$connectionType] = [ | ||
| $builder->model->getConnection()->getDriverName(), |
There was a problem hiding this comment.
Shouldn't this be $builder->modelConnectionType() ?
MeiKatz
reviewed
Oct 10, 2025
| $connectionType = $builder->model->getConnection()->getDriverName(); | ||
| [$connectionType] = [ | ||
| $builder->modelConnectionType(), | ||
| ]; |
There was a problem hiding this comment.
Sorry to bother you again but why are you converting the model connection type to an array with one element just to retrieve the first and only element right after? Wouldn't it be easier to assign the connection type directly?
$connectionType = $builder->modelConnectionType();There was a problem hiding this comment.
Yeah I was assigning multiple variables here in an earlier version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of improvements to full-text support when using the
databaseengine.orWhereFullTextin a single call.