Skip to content

Conversation

jtcorbett
Copy link
Contributor

@jtcorbett jtcorbett commented Sep 4, 2025

Summary

Added a new mcp cloud open command that opens the MCP Agent Cloud portal in a web browser. This command can either open the main dashboard or a specific deployment details page when provided with a server ID or URL.

Changelist

Added a new open_portal function that opens the MCP Agent Cloud portal in a browser

Integrated the command into the CLI structure under the cloud namespace

Created necessary module structure with proper imports and Bazel build configuration

Refactored URL constants to use a base URL for both web portal and API endpoints

Test Plan

# Open the main dashboard
mcp cloud open

# Open a specific deployment by server ID
mcp cloud open --server server123

# Open a specific deployment by URL
mcp cloud open --server https://mcp-agent.com/deployments/server123

@jtcorbett jtcorbett changed the title add cloud open Add cloud open command to open MCP Agent Cloud portal in browser Sep 4, 2025
Copy link
Contributor Author

jtcorbett commented Sep 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jtcorbett jtcorbett mentioned this pull request Sep 4, 2025
@jtcorbett jtcorbett marked this pull request as ready for review September 4, 2025 15:42
@rholinshead
Copy link
Member

The cloud portal is limited to just the api keys page for MVP so I don't think we want this command atm

@jtcorbett jtcorbett force-pushed the 09-04-add_cloud_open branch from ac44aad to f3f0b8f Compare September 4, 2025 15:47
Copy link

coderabbitai bot commented Sep 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-04-add_cloud_open

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jtcorbett jtcorbett force-pushed the 09-04-add_cloud_open branch from f3f0b8f to 40f9ee6 Compare September 4, 2025 15:52
Copy link
Member

@rholinshead rholinshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revisit this once the portal UI is implemented post-MVP

if server:
if server.startswith("http"):
# If it's a URL, try to extract server ID
url = f"{base_url}/deployments/{server.split('/')[-1]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation has a potential issue with trailing slashes in URLs. If server ends with a slash, server.split('/')[-1] will return an empty string, resulting in an invalid URL like https://mcp-agent.com/deployments/.

Consider handling trailing slashes explicitly:

url = f"{base_url}/deployments/{server.rstrip('/').split('/')[-1]}"

This ensures that even URLs ending with a slash will have their server ID correctly extracted.

Suggested change
url = f"{base_url}/deployments/{server.split('/')[-1]}"
url = f"{base_url}/deployments/{server.rstrip('/').split('/')[-1]}"

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@jtcorbett jtcorbett changed the base branch from jcorbett-add-cloud-auth to graphite-base/412 September 4, 2025 16:55
@jtcorbett jtcorbett marked this pull request as draft September 9, 2025 17:55
@jtcorbett jtcorbett removed the request for review from saqadri September 9, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants