sss: kill entire process group during decryption cleanup #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
When using SSS with multiple pins (e.g., tang) and threshold < n, after successful decryption with t pins, the remaining child processes and their grandchildren (like curl) were not being killed. The fix uses process groups for decryption only: - Add use_pgrp parameter to call() to control process group creation - For decryption: use_pgrp=true - child calls setpgid(0, 0) to become a process group leader, parent also calls setpgid() to eliminate race - For encryption: use_pgrp=false - no process groups needed since we wait for all children anyway - Cleanup uses kill(-pid, SIGTERM) to kill the entire process group - Falls back to direct kill if process group doesn't exist Signed-off-by: Sergio Correia <scorreia@redhat.com>
sergio-correia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SSS with multiple pins (e.g., tang) and threshold < n, after
successful decryption with t pins, the remaining child processes and
their grandchildren (like curl) were not being killed.
The fix uses process groups for decryption only:
a process group leader, parent also calls setpgid() to eliminate race
wait for all children anyway
Resolves: #460