Add ldcontext.NewBuilderWithCapacity constructor #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
To align experimentation across teams and deployments, we've wrapped your SDK in a library that we distribute across the org. This library abstracts away and standardizes most attributes that anyone would want to run an experiment against, and in doing so adds many attributes by default to each
ldcontext.Contextfor evaluations.When profiling a few deployments for unrelated reasons, we noted that allocations in
*ValueMapBuilder.Set(...)were usually at least visible in profiling although not egregiously so. Because we know the number of attributes we can define a capacity to pre-allocate and this would be a moderate reduction in allocations across a majority of our deployments.Describe the solution you've provided
Add a new constructor
ldcontext.NewBuilderWithCapacity(key string, capacity int)that utilizesldvalue.ValueMapBuilderWithCapacity(capacity int).Describe alternatives you've considered
I got cute with functional options for a second but I reeled it in.
Additional context
Benchmarks