Skip to content

fix: Reduce the chance of CurlEventPublisher exhausting file descriptors on high throughput PHP-FPM servers #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

fix: Reduce the chance of CurlEventPublisher exhausting file descriptors on high throughput PHP-FPM servers #216

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed19ae0
Use --max-time instead of --connect-timeout
Watercycle Mar 13, 2025
e5d53f1
Support --max-time and --connect-time
keelerm84 Mar 25, 2025
93a8399
Merge branch 'main' into event-publisher-resiliency
keelerm84 Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LaunchDarkly/Impl/Integrations/CurlEventPublisher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private function createCurlArgs(string $payload): string
{
$scheme = $this->_ssl ? "https://" : "http://";
$args = " -X POST";
$args.= " --connect-timeout " . $this->_connectTimeout;
$args.= " --max-time " . $this->_connectTimeout;
Copy link
Member

@keelerm84 keelerm84 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LDClient config already allows specifying both a connect_timeout and a max length timeout parameter. We use that timeout parameter in the existing Guzzle client.

Can you update this so that we still support the connect time parameter as before, and also add the max time flag hooked up to that value?


foreach ($this->_eventHeaders as $key => $value) {
if ($key == 'Authorization') {
Expand Down
Loading