fix: Fix data and target availability for daemon mode #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adjust availability calculations in FDv1/FDv2 and add tests for offline, LDD, data-source, and store-initialization states.
ldclient/impl/datasystem/fdv1.py):data_availabilityto returnCACHEDin LDD mode only when the store is initialized; otherwiseDEFAULTS.target_availabilityto returnCACHEDin LDD mode;DEFAULTSwhen offline; otherwiseREFRESHED.ldclient/impl/datasystem/fdv2.py):config.offlinedirectly instart()to disable the system.data_availability:REFRESHEDwhen selector is defined;CACHEDwhen store initialized; elseDEFAULTS.target_availability:DEFAULTSwhen offline or no data sources and no store;REFRESHEDwhen configured with data sources; otherwiseCACHED.test_fdv1_availability.pycovering offline, LDD (initialized/uninitialized), and normal mode scenarios.test_fdv2_datasystem.pywith availability cases for offline, with/without data sources, and read-only/read-write store (initialized/uninitialized).Written by Cursor Bugbot for commit 1c998cd. This will update automatically on new commits. Configure here.