-
Notifications
You must be signed in to change notification settings - Fork 130
docs(identity): Document behavior of linking social sign-ins #235 #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…#235 This PR adds documentation under `identity/` explaining the behavior of linking multiple social sign-in accounts in Layer5 Cloud. Signed-off-by: Ayush More <ayushmore42595@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ayushmore1214, you shouldn't create a new page for this. You can first check if the content from the issue has been written on this page(https://docs.layer5.io/cloud/identity/users/#account-linking). If not, please add it. If it has been written, we can close this issue. 👍
Good advice. Thank you for offering guidance here, @zihanKuang. @Ayushmore1214, have you reflected on the existing content? |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ayushmore1214, I have a couple of questions:
- Have you personally tested the behavior described in the issue? Could you clarify what "primary account" refers to?
- Why is this content placed under "Account Deletion" instead of "Account Linking"?
Yes, I did test this behavior personally to make sure the documentation reflects how it actually works. Good catch. By "primary account," I meant the first social account a user signs up with. Ypu are right the location is messed up I'll fix it |
Thanks for the effort! The changes are quite different from what's needed and would require several iterations. Let's close this PR for now. |
This PR adds documentation under
identity/
explaining the behavior of linking multiple social sign-in accounts in Layer5 Cloud.Notes for Reviewers
This PR fixes #235
Signed commits