Skip to content

Replace: Color Images with Cards and Copiable Code on Sistent Colors page #6477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Replace: Color Images with Cards and Copiable Code on Sistent Colors page #6477

wants to merge 16 commits into from

Conversation

M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented May 23, 2025

Description

This PR fixes #6474

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

M-DEV-1 added 2 commits May 23, 2025 17:33
@M-DEV-1
replace: images with color cards with copiable hex codes and sistent …
7208b7f 
…tokens

Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
fix: grammar
f41d7b0 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
M-DEV-1
M-DEV-1 commented May 23, 2025
View reviewed changes
src/sections/Projects/Sistent/identity/color/index.js
onClick={() => handleCopy(hex)}
aria-label={`Copy HEX color code of ${name}`}
sx={{
color: theme.palette.icon?.default,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to render correctly

M-DEV-1
M-DEV-1 commented May 23, 2025
View reviewed changes
src/sections/Projects/Sistent/identity/color/index.js Outdated
const colors = [
{
name: "Keppel Green",
color: theme.palette.background.brand?.default,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colors aren't rendering from the sistent tokens, not sure why

@github-actions GitHub Actions
Copy link

View in catalog, Edit in playground or learn how to interpret Meshery Designs

@l5io
Copy link
Contributor

l5io commented May 23, 2025

🚀 Preview for commit f41d7b0 at: https://683067b0f10c49787a9b0d3e--layer5.netlify.app

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 23, 2025

https://683067b0f10c49787a9b0d3e--layer5.netlify.app/projects/sistent/identity/color

@vr-varad
Copy link
Contributor

hey @M-DEV-1 is this issue resolved?

@l5io
Copy link
Contributor

l5io commented Jun 17, 2025

🚀 Preview for commit 8a48c84 at: https://6850e6337270c4bf3d7093b2--layer5.netlify.app

@M-DEV-1
add: rgb colors
9e36add 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 17, 2025

🚀 Preview for commit 9e36add at: https://6850ef155954f20c0351495a--layer5.netlify.app

M-DEV-1 and others added 4 commits June 17, 2025 10:17
@M-DEV-1
use copy button from sistent, fix rgb format
9741405 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
fix: copy button icon
c36e39a 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
add no-ssr
8525328 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
update and fix the copy icon import
0277257 
Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jun 17, 2025

🚀 Preview for commit 0277257 at: https://6850febc6cd7d0f26128c16a--layer5.netlify.app

@vr-varad
Copy link
Contributor

@M-DEV-1 Builds are failing

M-DEV-1
M-DEV-1 commented Jul 5, 2025
View reviewed changes
@M-DEV-1
replace @layer5/sistent with @sistent/sistent
74541ac 
Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jul 5, 2025

🚀 Preview for commit 74541ac at: https://68691054ab1426d56b4cabb5--layer5.netlify.app

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Jul 5, 2025 •
edited
Loading

@vr-varad build checks are passing now

https://68691054ab1426d56b4cabb5--layer5.netlify.app/projects/sistent/identity/color

@vr-varad
Copy link
Contributor

vr-varad commented Jul 5, 2025

Everything looks good. @M-DEV-1
Just one feature i would like to suggest would be, how about make them equally separable something like
justify-content: space-between, thoughts,
image

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Jul 6, 2025

Everything looks good. @M-DEV-1 Just one feature i would like to suggest would be, how about make them equally separable something like justify-content: space-between, thoughts, image

Yes, that's a good suggestion @vr-varad but the cards will become longer and they're already quite long, I supposed.

@l5io
Copy link
Contributor

l5io commented Jul 7, 2025

🚀 Preview for commit d534efc at: https://686c24c6f7db2305a6135183--layer5.netlify.app

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Jul 8, 2025

@vr-varad, I believe this is done. Can we get this merged?

@l5io
Copy link
Contributor

l5io commented Jul 8, 2025

🚀 Preview for commit 37e12b2 at: https://686ccb329f1c71b89cbf7e56--layer5.netlify.app

@stale Stale
Copy link

stale bot commented Jul 18, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 18, 2025
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 20, 2025
@l5io
Copy link
Contributor

l5io commented Jul 20, 2025

🚀 Preview for commit 804c77a at: https://687cb817fb5c2b6e12941bc3--layer5.netlify.app

Namanv0509
Namanv0509 approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@Namanv0509 Namanv0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LibenHailu
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Namanv0509 Namanv0509 Namanv0509 approved these changes

Assignees
No one assigned
Labels
project/sistent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Replace color images with copiable Hex/RGB codes on Sistent Identity Page
6 participants
@M-DEV-1 @l5io @vr-varad @LibenHailu @Namanv0509 @vishalvivekm