feat: extend the whitespace linter to proof bodies
#30658
+2,302
−405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o commandStart_more
…o whitespace/nplusone_to_n_plus_one
…o commandStart_more
…o whitespace/with_inv
…o commandStart_more
…o whitespace/with_inv
…o whitespace/with_inv
…o commandStart_more
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Jan 8, 2026
This PR ensures that pretty-printing of unification hints inserts a space after |- resp. ⊢. All uses in Lean core and mathlib add a space after the |- or ⊢ symbol; this makes the output match usage in practice. This was discovered in leanprover-community/mathlib4#30658, adding a formatting linter using pretty-printing as initial guide.
github-actions
bot
removed
merge-conflict
grunweg
commented
Jan 8, 2026
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Jan 8, 2026
Found by extending the whitespace linter to proof bodies in leanprover-community#30658.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Found by extending the whitespace linter to proof bodies in #30658.
It seems to complain on every library note; that's too noisy.
Collaborator
|
Hey 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grind_patternleanprover/lean4#11686commandStartlinter towhitespace#33708