fix: generate.sh and delete generated files #98
Conversation
| @@ -1,6 +1,6 @@ | |||
| <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" | |||
| "https://www.w3.org/TR/html4/strict.dtd"> | |||
| <html lange="en"> | |||
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Hardcoding the path of bash will force this execution plan. If the environment is using a different bash it won't work. This line will use the first one on the PATH.
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
| set -e | |||
There was a problem hiding this comment.
This will stop the script in case of failure.
pierluc-codes
requested review from
konsumlamm,
memowe,
smith558,
ulysses4ever and
xogcox
as code owners
|
I plan to review this over the weekend. Thanks! |
|
Could you please split configuration changes from textial changes in separate commits? Fire textual changes, why do you only change generated files and not source files? I'd expect source files to be changed as well. |
|
Thanks for your feedback.
There was modification to source that didn't update the generate files. I didn't change the source file, so it was 'catch up' for what is already on main :) For instance: #67 I would love to automate that at one point, but as a a first step, contributors should be able to run the generate script would be great :) For instance, this contribution didn't generate the docs: #92 |
pierluc-codes
force-pushed
the
pierluc-codes/fix-generation-script
branch
from
9fca6e8 to
8d511ff
Compare
|
@ulysses4ever I split the changes into two commits as requested :) |
There was a problem hiding this comment.
Makes sense, thank you!
So, Markdown already has these changes... Do you know anything about the top-level docs directory: does it have it or not? A random change that I tried to check (a mention of Haskell Discourse in Introduction) doesn't seem to be included in the version inside the docs. So, we have three slightly different versions (at times, at least). This is not a great place to be in. There should be some rationale documented somewhere (e.g. readme), as well as what path we would like to take from 3 versions to one.
|
After learning about the history of the |
pierluc-codes
force-pushed
the
pierluc-codes/fix-generation-script
branch
from
dda8137 to
1c57549
Compare
|
@ulysses4ever I think we can also delete generated_markdown. I went ahead and deleted both. The repo is configured to dismiss review on changes, so you will have to re approve. |
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Thanks!
Could you please update the PR title and description with the summary of the actual changes?
pierluc-codes
changed the title
Done! |
This PR generate.sh was not working because
By specifying the value, the script is not working.
I fix some typo, see comments inline.
@ulysses4ever and me decidd to delete the generated files (markdown and html) since it is very confusing.