Integrate with hamishforbes/lua-resty-qless-web and add lua-document support in IDE (idea+emmylua) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add lua-comments for each entry integrate with hamishforbes/lua-resty-qless-web support view-root parameter injection in initialization within resty-qless-web
|
Thanks for the contribution! How are those comments generated? I am concerned that they could easily fall out of date with changes. Is I'm not sure about merging in the web framework into this library, why not leave it in its separate package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add lua-comments for each entry
integrate with hamishforbes/lua-resty-qless-web
support view-root parameter injection in initialization within resty-qless-web