Skip to content

chore: runs tests against testnet and minor refactoring #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2024
Merged

chore: runs tests against testnet and minor refactoring #6

merged 2 commits into from
Dec 9, 2024

Conversation

cesarenaldi
Copy link
Member

No description provided.

@height Height
Copy link

height bot commented Dec 9, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@absis absis self-requested a review December 9, 2024 18:07
absis
absis requested changes Dec 9, 2024
View reviewed changes
.github/workflows/snapshot.yml

publish:
name: Publish Snapshot
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs-on: [self-hosted, linux, x64, lens, "staging"] -> this will use our own runners

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same on the other workflows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason? nothing particurlarly resource demanding in this workflow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@absis I gave it a try, but the jobs wait forever for the runner to be allocated. Is it possible this setup is only for the lens-protocol org and not the lens-network?

@cesarenaldi cesarenaldi force-pushed the chore/maintenance branch 17 times, most recently from 5c55a33 to 50a0057 Compare December 9, 2024 19:52
@cesarenaldi cesarenaldi merged commit 0f60c3c into main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absis absis absis requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cesarenaldi @absis