Skip to content

Fix FluentWindow background with None backdrop extending into window #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix FluentWindow background with None backdrop extending into window #1505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75cc286
Update FluentWindow.cs
Nuklon Aug 7, 2025
ec19b84
Update FluentWindow.cs
Nuklon Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions src/Wpf.Ui/Controls/FluentWindow/FluentWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ static FluentWindow()
protected override void OnSourceInitialized(EventArgs e)
{
OnCornerPreferenceChanged(default, WindowCornerPreference);
OnExtendsContentIntoTitleBarChanged(default, ExtendsContentIntoTitleBar);
OnExtendsContentIntoTitleBarChanged(false, ExtendsContentIntoTitleBar);
OnBackdropTypeChanged(default, WindowBackdropType);

base.OnSourceInitialized(e);
Expand Down Expand Up @@ -182,10 +182,11 @@ protected virtual void OnBackdropTypeChanged(WindowBackdropType oldValue, Window
return;
}

SetWindowChrome();

if (newValue == WindowBackdropType.None)
{
_ = WindowBackdrop.RemoveBackdrop(this);

return;
}

Expand Down Expand Up @@ -233,20 +234,26 @@ protected virtual void OnExtendsContentIntoTitleBarChanged(bool oldValue, bool n
// AllowsTransparency = true;
SetCurrentValue(WindowStyleProperty, WindowStyle.SingleBorderWindow);

WindowChrome.SetWindowChrome(
this,
new WindowChrome
{
CaptionHeight = 0,
CornerRadius = default,
GlassFrameThickness = new Thickness(-1),
ResizeBorderThickness = ResizeMode == ResizeMode.NoResize ? default : new Thickness(4),
UseAeroCaptionButtons = false,
}
);

// WindowStyleProperty.OverrideMetadata(typeof(FluentWindow), new FrameworkPropertyMetadata(WindowStyle.SingleBorderWindow));
// AllowsTransparencyProperty.OverrideMetadata(typeof(FluentWindow), new FrameworkPropertyMetadata(false));
_ = UnsafeNativeMethods.RemoveWindowTitlebarContents(this);
}

/// <summary>
/// This virtual method is called when <see cref="WindowBackdropType"/> is changed.
/// </summary>
protected virtual void SetWindowChrome()
{
WindowChrome.SetWindowChrome(
this,
new WindowChrome
{
CaptionHeight = 0,
CornerRadius = default,
GlassFrameThickness = WindowBackdropType == WindowBackdropType.None ? new Thickness(0.00001) : new Thickness(-1), // 0.00001 so there's no glass frame drawn around the window, but the border is still drawn.
ResizeBorderThickness = ResizeMode == ResizeMode.NoResize ? default : new Thickness(4),
UseAeroCaptionButtons = false,
}
);
}
}