Add setting border color + fix background extending inside FluentWindow #1508
+126
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
controls
Nuklon
commented
Aug 8, 2025
| dwAttribute = Dwmapi.DWMWINDOWATTRIBUTE.DMWA_USE_IMMERSIVE_DARK_MODE_OLD; | ||
| } | ||
|
|
||
| // TODO: Validate HRESULT |
There was a problem hiding this comment.
I also corrected this, it's only returning 0 on success.
It's actually SystemAccent used by Windows.
|
Border is now only active when focused (same as WinUI). When deactivated it gets back to default OS color. |
7 tasks
|
This also fixes FluentWindow background with None backdrop extending into window. Taken from #1505. |
Nuklon
changed the title
Nuklon
commented
Aug 11, 2025
| { | ||
| CaptionHeight = 0, | ||
| CornerRadius = default, | ||
| GlassFrameThickness = WindowBackdropType == WindowBackdropType.None ? new Thickness(0.00001) : new Thickness(-1), // 0.00001 so there's no glass frame drawn around the window, but the border is still drawn. |
There was a problem hiding this comment.
This is the fix for FluentWindow. -1 cannot be used if None is specified, otherwise the background of the window is rendered 1 pixel inside, which is obviously wrong.
Nuklon
commented
Sep 28, 2025
| { | ||
| try | ||
| { | ||
| if (Utilities.IsCompositionEnabled) |
There was a problem hiding this comment.
Addresses: COMException: {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (Exception from HRESULT: 0x80263001).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, WPF-UI doesn't set the border color based on accent. This adds that.
Old left, right new.