Skip to content

Fix RadioButton style #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix RadioButton style #1522

wants to merge 4 commits into from

Conversation

Nuklon
Copy link

@Nuklon Nuklon commented Aug 26, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

There are various issues with RadioButton, which have all been resolved:

  • Padding didn't work.
  • Glyph was too large compared to WinUI.
  • Mouse over animations were disabled (had a TODO comment), I've reenabled them, they work OK if you stop the other storyboards first.
  • Fix glyph alignment (Grid should also be height 20 and then the outer element have height 32) so the ellipsis are centered correctly.
  • Change to VerticalContentAlignment = Center to follow WinUI.
  • Fix incorrect hover/pressed colors.
  • Add various missing animations (e.g., when pressing from a checked/unchecked the glyph animates as well).
  • Remove Cursor=Hand, this isn't used by WinUI.
Wpf.Ui.Gallery_kQQJegC94F.mp4

@Nuklon Nuklon requested a review from pomianowski as a code owner August 26, 2025 16:21
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Aug 26, 2025
Nuklon
Nuklon commented Aug 26, 2025
View reviewed changes
src/Wpf.Ui/Controls/RadioButton/RadioButton.xaml
<ScaleTransform ScaleX="1.0" ScaleY="1.0" />
</Ellipse.LayoutTransform>
</Ellipse>
<!-- A separate element is added since the two orthogonal state groups that cannot touch the same property -->
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed this, it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski Awaiting requested review from pomianowski pomianowski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Nuklon