Skip to content

fix: make notifyicon contextmenu display #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make notifyicon contextmenu display #1534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Wpf.Ui.Gallery/Views/Windows/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
MenuOnRightClick="True"
TooltipText="WPF UI Gallery">
<tray:NotifyIcon.Menu>
<ContextMenu ItemsSource="{Binding ViewModel.TrayMenuItems, Mode=OneWay}" />
<ContextMenu DataContext="{Binding DataContext, Source={x:Reference NavigationView}}" ItemsSource="{Binding ViewModel.TrayMenuItems, Mode=OneWay}" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think x:Reference is discouraged, but I'm only not sure after reading https://learn.microsoft.com/en-us/dotnet/desktop/xaml-services/xreference-markup-extension#xreference-and-wpf.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

   <tray:NotifyIcon
       FocusOnLeftClick="True"
       MenuOnRightClick="True">
       <tray:NotifyIcon.Resources>
           <DiscreteObjectKeyFrame x:Key="proxy" Value="{Binding}"/>
       </tray:NotifyIcon.Resources>
       <tray:NotifyIcon.Menu>
           <ContextMenu  DataContext="{Binding Source={StaticResource proxy},Path=Value}">
               <ui:MenuItem
                   Name="OpenSettings"
                   Command="{Binding OpenSettingsCommand}"
                   CommandParameter="123"
                   Header="{x:Static str:Resources.AppSetting}" />
               <ui:MenuItem
                   Name="Exit"
                   Command="{Binding ExitAppCommand}"
                   Header="{x:Static str:Resources.AppExit}" />
           </ContextMenu>
       </tray:NotifyIcon.Menu>
   </tray:NotifyIcon>

ok,i have plan b

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chucker
I have provided two of my common practices. My approach is to solve it through XAML:

  • Using x:Referenceto traverse the visual tree.
  • Using a lazy-loading object (I directly borrowed the DiscreteObjectKeyFramefrom the WPF animation system).

Can we discuss your thoughts? What fixes are planned?

Maybe we could start by getting something done, even if it's not the final solution? The Wpf.Ui.Gallery is a sample project, so we can always change it later if we think of a better way.

</tray:NotifyIcon.Menu>
</tray:NotifyIcon>
</Grid>
Expand Down
Loading