perf: use a set instead of Vec<_>
to optimize large subscriber sets (see #4138)
#4201
+27
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bicarlsen At your convenience, could you please test this against the performance issue discussed in #4138?
The tradeoffs here are probably:
Vec<_>
lookup being cheaper than hashmap lookup for very small cases) -- but this is not likely to be measurable because it's from "very fast" to "also very fast"Let me know if it helps with your case and we can swap it out. I don't think the downsides are a good argument against it.