Skip to content

[DO NOT MERGE] Tests coveralls #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Tests coveralls #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da20644
👷chore: Upload coverage data to Coveralls with CI
negokaz Nov 25, 2021
0df4ca6
📚doc: Add a badge that notices coverage status
negokaz Nov 25, 2021
079f9d1
👷chore: Bump up sbt-scoverage version to 1.8.2
negokaz Nov 25, 2021
4a45ca9
test
negokaz Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ jobs:
report_paths: 'target/**test-reports/TEST-*.xml'
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Check the test coverage is above the minimum criteria
run: sbt coverageAggregate
- name: Check the test coverage is above the minimum criteria and upload coveage data to Coveralls
run: sbt coverageAggregate coveralls
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# https://www.scala-sbt.org/1.x/docs/GitHub-Actions-with-sbt.html#Caching
- name: Clean files for caching
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ akka-entity-replication
===

[![CI](https://github.com/lerna-stack/akka-entity-replication/workflows/CI/badge.svg?branch=master)](https://github.com/lerna-stack/akka-entity-replication/actions?query=workflow%3ACI+branch%3Amaster)
[![Coverage Status](https://coveralls.io/repos/github/lerna-stack/akka-entity-replication/badge.svg)](https://coveralls.io/github/lerna-stack/akka-entity-replication)

## Introduction

Expand Down
4 changes: 3 additions & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-multi-jvm" % "0.4.0")

addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.25")

addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.6.1")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.8.2")

addSbtPlugin("org.scoverage" % "sbt-coveralls" % "1.3.1")

addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")

Expand Down
5 changes: 5 additions & 0 deletions src/main/scala/lerna/akka/entityreplication/raft/RaftMemberData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,11 @@ private[entityreplication] trait RaftMemberData
to <= lastApplied,
s"Cannot select the entries (${from}-${to}) unless RaftActor have applied the entries to the entities (lastApplied: ${lastApplied})",
)
if (1 == 2) {
println("uncovered")
} else {
println("covered")
}
replicatedLog.sliceEntries(from, to).filter(_.event.entityId.contains(entityId))
}

Expand Down