Bhaskar #4372
Open
Bhaskar #4372
+15,725
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables and modern CSS support
…iables in min()/max() and handling calc() expressions correctly. Operations with CSS variables now work at runtime, and error messages are more precise, showing the exact operation and types. These changes enhance CSS compatibility, reliability, and developer experience.
Fixes: 1. Line comments (//) now properly stripped in permissive parsing contexts - Added line comment detection in parser-input.js parseUntil function - Handles line comments in custom properties, @supports, and other contexts - Test cases added in packages/test-data/less/line-comments/ 2. Document extend/variable scope behavior (issue less#3706) - Clarified that extend works after variable evaluation - Provided 3 workaround patterns: mixins, CSS custom properties, explicit override - Test cases added in packages/test-data/less/extend-variable-scope/ Documentation added: - README-DOCS.md: Navigation index - QUICK-REFERENCE.md: One-page reference - EXTEND-VARIABLE-SCOPE-GUIDE.md: Comprehensive guide - COMPILATION-FLOW-DIAGRAM.md: Visual diagrams - IMPLEMENTATION-SUMMARY.md: Technical details - FINAL-SUMMARY.md: Completion summary - verify-line-comments-fix.js: Verification script - direct-test.js: Source validation script
dosubot
bot
added
the
size:XXL
|
i request @puckowski to verify my Pull request As fast as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments with doubleslash are not stripped before compile #4264
What changes are being made? (What feature/bug is being fixed here?
What: Result 1 Bug Fixed - Line comments now properly stripped
Comprehensive Documentation - 6 guides + 2 verification scripts
All Changes Committed - To branch Bhaskar (commit: 131356e)
@puckowski
#4264