test: verify pre-commit workflow with formatting issues #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains various formatting issues to test the pre-commit workflow: - Extra trailing whitespace - Missing final newline - Inconsistent indentation - Improper spacing around operators - Missing spaces after braces
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+10
to
+13
| resource "aws_kms_key" "backup"{description="Test KMS key" | ||
|
|
||
| # Inconsistent indentation and spacing | ||
| deletion_window_in_days=7} |
Check failure
Code scanning / checkov
Ensure rotation for customer created CMKs is enabled Error test
Comment on lines
+10
to
+13
| resource "aws_kms_key" "backup"{description="Test KMS key" | ||
|
|
||
| # Inconsistent indentation and spacing | ||
| deletion_window_in_days=7} |
Check failure
Code scanning / checkov
Ensure KMS key Policy is defined Error test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Purpose
This PR is created to verify that the pre-commit workflow is working correctly by introducing intentional formatting issues.
Expected Behavior
The pre-commit workflow should:
test_formatting.tfTest File Contents
The test file
test_formatting.tfcontains intentional formatting violations to validate that:trailing-whitespacehook catches extra spacesend-of-file-fixerhook detects missing final newlinesterraform_fmthook identifies Terraform formatting issuesSuccess Criteria
✅ Pre-commit workflow triggers on this PR
✅ Workflow identifies formatting issues in the test file
✅ Workflow provides clear error messages and suggestions
✅ Incremental file checking works (only tests changed files)
This test validates that our pre-commit automation is properly protecting code quality.