Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Issue

Why is this change needed?

This change removes the redundant evaluateSchema CLI command from the schema-bench package. The functionality provided by this command is fully covered by evaluateSchemaMulti, which can handle both single and multiple dataset evaluations. This simplifies the codebase by removing duplicate functionality that was not being used in practice.

What was changed?

  • Removed CLI script: Deleted src/cli/evaluateSchema.ts (44 lines)
  • Updated package.json: Removed the "evaluateSchema" script entry
  • Preserved internal function: The internal evaluateSchema function in evaluation.ts remains intact and continues to be used by evaluateSchemaMulti and tests

Migration path

Instead of:

pnpm --filter @liam-hq/schema-bench evaluateSchema --case=case-001

Use:

pnpm --filter @liam-hq/schema-bench evaluateSchemaMulti logical-deletion

Human Review Checklist

  • Verify internal function preservation: Confirm the evaluateSchema function in evaluation.ts is still accessible and working (tests pass but worth double-checking)
  • Test single dataset evaluation: Verify that evaluateSchemaMulti can handle single dataset evaluation as intended
  • Check for other references: Search for any remaining references to the removed CLI command in documentation, CI/CD scripts, or other files
  • Validate requirements alignment: Confirm this removal aligns with the original GitHub issue requirements
  • Consider usage impact: Verify no existing workflows or users depend on the removed CLI command

Session Info: Implemented by noritaka.ikeda@route06.co.jp
Link to Devin run: https://app.devin.ai/sessions/631dd75b8e6f4640986f39ad5990dbe2

- Remove src/cli/evaluateSchema.ts CLI script that was redundant
- Remove 'evaluateSchema' script entry from package.json
- Preserve internal evaluateSchema function used by evaluateSchemaMulti and tests
- All tests continue to pass, functionality remains intact

The evaluateSchemaMulti command provides the same functionality and can handle both single and multiple dataset evaluations, making the standalone CLI command unnecessary.

Co-Authored-By: noritaka.ikeda@route06.co.jp <noritaka.ikeda@route06.co.jp>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: eeb2765

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Sep 26, 2025 10:15am
liam-assets Ready Ready Preview Comment Sep 26, 2025 10:15am
liam-storybook Ready Ready Preview Comment Sep 26, 2025 10:15am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Sep 26, 2025 10:15am
liam-erd-sample Skipped Skipped Sep 26, 2025 10:15am

Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

supabase bot commented Sep 26, 2025

Updates to Preview Branch (devin/1758881170-remove-unused-evaluateSchema-cli) ↗︎

Deployments Status Updated
Database Fri, 26 Sep 2025 10:12:02 UTC
Services Fri, 26 Sep 2025 10:12:02 UTC
APIs Fri, 26 Sep 2025 10:12:02 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Fri, 26 Sep 2025 10:12:07 UTC
Migrations Fri, 26 Sep 2025 10:12:12 UTC
Seeding Fri, 26 Sep 2025 10:12:12 UTC
Edge Functions Fri, 26 Sep 2025 10:12:12 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants