Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 7, 2025

Issue

  • Resolves: route06/liam-internal#5797

Why is this change needed?

The PublicGlobalNav currently expands on hover even though it only contains a logo with no additional content to show. This creates an awkward user experience where the sidebar expands to reveal empty space. The hover animation should be disabled for public pages while preserving it for internal pages where the navigation actually has content.

Changes Made

  1. Added disableHover prop to BaseGlobalNav - Optional boolean prop that defaults to false for backward compatibility
  2. Updated CSS hover selector - Changed from .globalNav:hover to :not([data-disable-hover]) .globalNav:hover to conditionally apply hover styles
  3. Applied disableHover to PublicGlobalNav - Passes disableHover={true} to prevent hover animation on public pages

Testing

Screen.Recording.2025-10-07.at.15.44.21.mov

Review Focus Areas

  • CSS selector correctness: Verify :not([data-disable-hover]) .globalNav:hover targets the right elements
  • Backward compatibility: Ensure existing GlobalNav hover behavior is unchanged
  • Data attribute logic: Check that data-disable-hover={disableHover || undefined} works correctly

Requested by: @MH4GF
Link to Devin run: https://app.devin.ai/sessions/14347d39aa9741aca909efaed7d91694

…mation on PublicGlobalNav

Co-Authored-By: hirotaka.miyagi@route06.co.jp <h.miyagi.cnw@gmail.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: c96dfcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Oct 7, 2025 6:37am
liam-assets Ready Ready Preview Comment Oct 7, 2025 6:37am
liam-docs Ready Ready Preview Comment Oct 7, 2025 6:37am
liam-erd-sample Ready Ready Preview Comment Oct 7, 2025 6:37am
liam-storybook Ready Ready Preview Comment Oct 7, 2025 6:37am

Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Note

Free review on us!

CodeRabbit is offering free reviews until Wed Oct 08 2025 to showcase some of the refinements we've made.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

supabase bot commented Oct 7, 2025

Updates to Preview Branch (devin/1759816514-disable-public-nav-hover-animation) ↗︎

Deployments Status Updated
Database Tue, 07 Oct 2025 06:33:10 UTC
Services Tue, 07 Oct 2025 06:33:10 UTC
APIs Tue, 07 Oct 2025 06:33:10 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Tue, 07 Oct 2025 06:33:11 UTC
Migrations Tue, 07 Oct 2025 06:33:11 UTC
Seeding Tue, 07 Oct 2025 06:33:11 UTC
Edge Functions Tue, 07 Oct 2025 06:33:11 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Co-Authored-By: hirotaka.miyagi@route06.co.jp <h.miyagi.cnw@gmail.com>
…ector

Co-Authored-By: hirotaka.miyagi@route06.co.jp <h.miyagi.cnw@gmail.com>
@MH4GF MH4GF marked this pull request as ready for review October 7, 2025 06:45
@MH4GF MH4GF requested a review from a team as a code owner October 7, 2025 06:45
@MH4GF MH4GF requested review from NoritakaIkeda, Copilot and junkisai and removed request for a team October 7, 2025 06:45
@MH4GF MH4GF requested a review from sasamuku October 7, 2025 06:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a disableHover prop to BaseGlobalNav to prevent hover animations on public pages where the navigation contains only a logo with no additional content to display.

  • Added enableHover prop to BaseGlobalNav with backward-compatible default of true
  • Updated CSS hover selector to conditionally apply based on data-disable-hover attribute
  • Applied enableHover={false} to PublicGlobalNav to disable hover animation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
BaseGlobalNav.tsx Added enableHover prop and data attribute to control hover behavior
BaseGlobalNav.module.css Updated CSS selector to conditionally apply hover styles
PublicGlobalNav.tsx Disabled hover animation by setting enableHover={false}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

.globalNav:hover {
:not([data-disable-hover]) > .globalNav:hover {
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selector uses child combinator > but should use descendant combinator (space) since .globalNav is not a direct child of the element with data-disable-hover. The correct selector should be :not([data-disable-hover]) .globalNav:hover.

Suggested change
:not([data-disable-hover]) > .globalNav:hover {
:not([data-disable-hover]) .globalNav:hover {

Copilot uses AI. Check for mistakes.

Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@junkisai junkisai added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit b8f2acb Oct 7, 2025
35 checks passed
@junkisai junkisai deleted the devin/1759816514-disable-public-nav-hover-animation branch October 7, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants