-
Notifications
You must be signed in to change notification settings - Fork 177
✨ feat(command palette): support Column options #3732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+455
−13
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e5c1656
🧪 activate table mode for implementation
tnyo43 21e2272
✨ add TableColumnOptions base copied from TableOptions component
tnyo43 cbea656
✨ add new option type: 'column'
tnyo43 af601ee
✨ update suggestion convert functions
tnyo43 8d6579f
✨ add function to build href for column option
tnyo43 0e401bd
✨ add column options
tnyo43 1e84699
✨ add keyboard listeners
tnyo43 d0c3c50
✨ set column type icons based on column and constraints information
tnyo43 6a85cff
✨ set isTableModeActivatable on CommandPaletteContent to switch table…
tnyo43 242f9dc
💄 show TablePreview when a column is suggested
tnyo43 3e98996
✨ customize filter for table input mode
tnyo43 04295f9
🧪 add isTableModeActivatable for checking
tnyo43 5493d3d
Revert "🧪 add isTableModeActivatable for checking"
tnyo43 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isTableModeActivatable
will befalse
by default, so it won't be displayed for the users yet.