Skip to content

VariationalMeshSmoother: Support for higher order elements #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 31, 2025
Merged

VariationalMeshSmoother: Support for higher order elements #4218

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1524d5e
Improved the VariationalMeshSmoother tester
pbehne Jul 24, 2025
261a0fa
Added tests for EDGE3, HEX20 elements
pbehne Jul 24, 2025
39fcac2
Added support and tests for TRI6 elements
pbehne Jul 24, 2025
b354456
Added support and tests for HEX27 elements.
pbehne Jul 25, 2025
039f15c
Delete trailing whitespace
pbehne Jul 28, 2025
a00f377
Removed assertion I wrote when I was stupid.
pbehne Jul 28, 2025
7a718fb
Replaced dynamic cast with compile-time conditional.
pbehne Jul 29, 2025
84ec3c0
Consolidated code by using Elem::build.
pbehne Jul 29, 2025
f74447f
Made ref_area const.
pbehne Jul 29, 2025
e6bc76c
Use non-deprecated set_node.
pbehne Jul 30, 2025
7345f23
Merge remote-tracking branch 'origin/devel' into variational_smoother…
jwpeterson Jul 30, 2025
8d5a268
Addressed John's review.
pbehne Jul 30, 2025
ead09fc
Changed instance of std::pow to Utility::pow.
pbehne Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/systems/variational_smoother_system.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ void VariationalSmootherSystem::prepare_for_smoothing()
// Scale the nodal positions to conserve area
auto node_ptr = std::make_unique<Node>(
equilateral_points[node_id] * side_length, node_id);
target_elem->set_node(node_id) = node_ptr.get();
target_elem->set_node(node_id, node_ptr.get());
Copy link
Member

@jwpeterson jwpeterson Jul 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll make a separate PR with just this fix as well, it shouldn't conflict with #4218 and it will give us a working --disable-deprecated build before #4218 just in case that is useful for debugging for some reason...


// Store the pointer so it stays alive
owned_nodes.push_back(std::move(node_ptr));
Expand Down